Fix Quote block transform error when no paragraph blocks exist#74320
Fix Quote block transform error when no paragraph blocks exist#74320sarthak-19 wants to merge 1 commit into
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sarthak-19! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
@sarthak-19 Thanks for the PR! Sorry, but let me close this PR since there is already an ongoing #74236. |
What?
Fixes #74236 a TypeError that occurs when attempting to transform a Quote block to paragraphs when the Quote block doesn't contain any paragraph inner blocks.
Why?
The transform function was incorrectly accessing block data:
valueattribute instead ofinnerBlocksparameterisMatchfunction wasn't properly validating the presence of paragraph blocksCannot read properties of null (reading 'name')How
block.innerBlocksto verify at least one paragraph block exists before allowing the transform.