Skip to content

Autocomplete: Add offset to popover#74084

Merged
mirka merged 2 commits intotrunkfrom
autocomplete-offset
Dec 18, 2025
Merged

Autocomplete: Add offset to popover#74084
mirka merged 2 commits intotrunkfrom
autocomplete-offset

Conversation

@mirka
Copy link
Member

@mirka mirka commented Dec 17, 2025 •
edited
Loading

Stacked on #74082

What?

Adds a slight offset to the Autocomplete popover so it isn't uncomfortably close to the cursor.

Why?

It's basically touching the cursor because there isn't any offset between the popover and the anchor.

Testing Instructions

Try the / or @ autocompleters in the block editor.

Screenshots or screencast

Before

CleanShot.2025-12-18.at.05-43-53.mov

After

CleanShot.2025-12-18.at.05-42-17.mov

@mirka mirka self-assigned this Dec 17, 2025
@mirka mirka requested a review from ajitbohra as a code owner December 17, 2025 22:40
@mirka mirka added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Dec 17, 2025
@github-actions
Copy link

github-actions bot commented Dec 17, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested review from a team December 17, 2025 22:41
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Flaky tests detected in d9ee6e2.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20319556959
📝 Reported issues:

Mamaduka
Mamaduka approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mirka!

jasmussen
jasmussen approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a nice polish. Thank you.

Base automatically changed from popover-motion to trunk December 18, 2025 11:36
@mirka mirka force-pushed the autocomplete-offset branch from d9ee6e2 to 445727a Compare December 18, 2025 11:41
@mirka mirka enabled auto-merge (squash) December 18, 2025 11:41
@mirka mirka merged commit b5146cf into trunk Dec 18, 2025
44 of 45 checks passed
@mirka mirka deleted the autocomplete-offset branch December 18, 2025 12:24
@github-actions github-actions bot added this to the Gutenberg 22.4 milestone Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@jasmussen jasmussen jasmussen approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@mirka mirka

Labels

[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 22.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mirka @Mamaduka @jasmussen