Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in f566317. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20316980851
|
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
I'm a big fan, much snappier. I'll defer to others with strong opinions, and for a dev check, but a quick 👍 👍 from my end.
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
Big fan of this change as well! I've tested on my local, and the separate components in Storybook.
The animations look great in the context of the editor. The new timing feels much more subtle and polished. The code looks good to me as well ✅
popover-animation.mp4
3 participants
What?
Part of ##74079
Updates the animation of
Popoverto the new motion specs.Affected
@wordpress/componentsWhy?
Animation like this is inconsistent throughout the component system, and sometimes feels a bit laggy. We need a refreshed animation that can be applied globally.
Testing Instructions
Much of the block editor will feel changed, so check how things feel there.
For isolated testing, see the affected components in Storybook.
Screenshots or screencast
Before
before.mov
After
after.mov