Template Activation: Make template edit test less flaky again#74066
Merged
Template Activation: Make template edit test less flaky again#74066
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
Member
Author
Mamaduka
approved these changes
Dec 17, 2025
Comment on lines
96
to
99
| const saveButton = ( await publishSaveButton.isVisible() ) | ||
| ? publishSaveButton | ||
| : topBarSaveButton; | ||
| await saveButton.click(); |
Member
There was a problem hiding this comment.
We can also use locator.or helper here.
await publishSaveButton.or( topBarSaveButton ).click()Here's example from code base:
Member
Author
There was a problem hiding this comment.
Fab, thanks! Switched to use this in a3dc4c2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #73752
Follow-up to #73975
Why? / How?
Attempts to fix this test to make it less flaky again, this time by checking for the save button in both the Editor top bar and the publish area.
Testing Instructions
All tests should pass first time.