Fix E2E test selector for navigation link list view selection#74030
Draft
Fix E2E test selector for navigation link list view selection#74030
Conversation
…ist view Co-authored-by: getdave <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix LinkPicker to preserve custom label when adding URL
Fix E2E test selector for navigation link list view selection
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E test for preserving custom labels when adding URLs to navigation links was failing due to an incorrect selector that searched the entire page instead of scoping to the navigation list view.
Changes
navigation.spec.jsto properly access the navigation list view treegrid before selecting the "Empty Link" itemopenDocumentSettingsSidebar()call since it's now needed earlier in the test flowThe underlying implementation in
use-handle-link-change.jscorrectly preserves custom labels by conditionally including the title only when no label exists.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.