Real-time collaboration: Do not overwrite a "floating" date#73984
Real-time collaboration: Do not overwrite a "floating" date#73984chriszarate merged 1 commit intotrunkfrom
Conversation
chriszarate
added
[Type] Bug
|
Flaky tests detected in c39189b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20182723379
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 participants
What?
When applying changes from remote CRDT documents, do not overwrite a "floating date" for draft or pending post statuses.
Why?
A "floating date" encodes the current time (or is
null) as a signal that a post will be published immediately. We don't want to adopt a post date from a remote peer unless it is accompanied by a meaningful post status change (e.g, toscheduled).How?
Remove the value check to make sure floating dates are never overwritten for draft or pending post statuses.