Add experiment for hiding blocks based on screen size#73949
Conversation
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
LGTM! I left a comment about how I think the text can be improved, but I'm not too fussy, feel free to merge it!
lib/experiments-page.php
Outdated
| __( 'Hide blocks based on screen size', 'gutenberg' ), | ||
| 'gutenberg_display_experiment_field', | ||
| 'gutenberg-experiments', | ||
| 'gutenberg_experiments_section', | ||
| array( | ||
| 'label' => __( 'Extends block visiblity block supports to hide blocks based on screen size.', 'gutenberg' ), |
There was a problem hiding this comment.
I think the title/description could be improved. It makes it sound like blocks are automatically hidden based on screen size without the user doing anything, but I think what it really will do is provide responsive design controls for hiding blocks.
There was a problem hiding this comment.
True indeed! I'll update
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 255d6c5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20158832601
|
2 participants
What?
Create initial experiment for #72502
Why?
This feature will be iteratively developed behind an experimental flag to start with to minimize impact on the current editor UX
How?
You know.
Testing Instructions
Check that the experiment is there in
/wp-admin/admin.php?page=gutenberg-experimentsEnable the experiment and check that
window.__experimentalHideBlocksBasedOnScreenSizeis available in the console.