DataViews: Fix row selection in table layout in Firefox#73945
Merged
Conversation
talldan
requested review from
aaronrobertshaw,
andrewserong,
jameskoster,
ramonjd and
tellthemachines
talldan
added
[Type] Bug
talldan
requested review from
gigitux,
ntsekouras and
oandregal
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
changed the title
tellthemachines
approved these changes
Dec 12, 2025
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
LGTM! Tested in Firefox and can confirm this fixes the issue.
talldan
deleted the
fix/dataview-table-prevent-firefox-cell-selection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #73910
Why?
Firefox has a unique feature compared to other browsers, Cmd/Ctrl + Click on a table cell selects the table cell. Try it below (Cmd + Click on a mac, Ctrl + Click on other platforms):
For the dataviews table layout, it already uses the same shortcut for table row selection. I think the Firefox behavior isn't something that's expected to happen, and it stops the row selection behavior from working, so this PR prevents it.
How?
If the browser is firefox, and the user ctrl/cmd + left clicks, prevent the default behavior.
Testing Instructions (in Firefox)
npm run storybook:dev