UI: Ensure Stack is exported from root package exports#73928
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
[Type] Task
|
Flaky tests detected in bf8e6d5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20172074697
|
jsnajdr
reviewed
Dec 12, 2025
| __dangerousOptInToUnstableAPIsOnlyForCoreModules( | ||
| 'I acknowledge private features are not for use in themes or plugins and doing so will break in the next version of WordPress.', | ||
| '@wordpress/dataviews' | ||
| ); |
Member
There was a problem hiding this comment.
We can also remove references to @wordpress/private-apis from package.json and tsconfig.json if we don't use it any more.
mirka
reviewed
Dec 12, 2025
packages/ui/src/test/index.test.ts
Outdated
| it( 'should export something from each component', async () => { | ||
| // As described in the CONTRIBUTING.md file, each component should be | ||
| // exported from an index.ts in its implementation directory. | ||
| const components = await glob( join( __dirname, '../*/index.ts' ) ); |
Member
There was a problem hiding this comment.
I'm paranoid about breaking in Windows again, could this need this kind of workaround?
For example I'm seeing a normalizer used here:
gutenberg/packages/wp-build/src/build.mjs
Lines 456 to 457 in b59a245
Member
Author
There was a problem hiding this comment.
I feel frustrated at the ambiguity that my answer to your question is "I don't know, and I can't easily confirm" 😕
For what it's worth, we recently enabled Windows checks on pull requests in #73923, though I need to rebase the branch for that to apply here, and it only covers "Static checks" (including npm run build), but not the unit tests, so it wouldn't help here.
Member
Author
There was a problem hiding this comment.
but not the unit tests, so it wouldn't help here.
Although to that point, it doesn't appear that we run unit tests in a Windows environment at any point, so we have no guarantees that the tests currently work on Windows machines 😬
Member
Author
There was a problem hiding this comment.
I've been dabbling a bit with using GitHub Codespaces and this seems like it'd be a great use for testing how code behaves on other systems, but sadly it only offers Linux containers at the moment.
Member
Author
There was a problem hiding this comment.
Okay, I understand better now why we have normalizePath, and the short answer to your question is "yes".
It's a requirement of fast-glob:
⚠️ Always use forward-slashes in glob expressions (patterns and ignore option). Use backslashes for escaping characters.
I think we won't need these workarounds once we upgrade to a version of Node.js that includes fs.glob, which I suspect will handle this better (available in Node.js v22+, see #72973).
fast-glob requires forward slashes. path.join produces backslashes in Windows environment. Simple fix is to avoid path.join
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
mirka
approved these changes
Dec 12, 2025
Co-authored-by: Lena Morita <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Ensures that the
Stackcomponent is exported from the@wordpress/uipackage.Follow-up to #73308
Why?
At the moment, the component cannot be used from the package.
How?
packages/ui/src/index.tsCHANGELOG.mdlock-unlock.tsfileTesting Instructions
import { Stack } from '@wordpress/ui';code snippet in some code file, and a corresponding"@wordpress/ui": "../ui"dependencies declaration in that code's closestpackage.jsonnpm run lint:jsScreenshots or screencast