Revert caption handling changes to maintain consistent image block behavior#73914
Merged
cbravobernal merged 2 commits intofix/remove-caption-block-editfrom Dec 12, 2025
Merged
Conversation
Co-authored-by: cbravobernal <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix feedback on removing caption in EditWithGeneratedProps
Revert caption handling changes to maintain consistent image block behavior
Dec 11, 2025
|
Size Change: -26 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6ab6762. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20132840427
|
talldan
approved these changes
Dec 12, 2025
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
LGTM! It's nice to be able to simplify some of this code 🎉
cbravobernal
approved these changes
Dec 12, 2025
cbravobernal
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Copilot. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
merged commit f8c924d
into
fix/remove-caption-block-edit
56 of 76 checks passed
cbravobernal
added a commit
that referenced
this pull request
Dec 15, 2025
…#73552) * Remove caption as comment requires * Make image caption the source of truth for overrides * Revert caption handling changes to maintain consistent image block behavior (#73914) * Initial plan * Revert caption handling to preserve existing behavior Unlinked contributors: Copilot. Co-authored-by: cbravobernal <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: ockham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Reverts changes from #73552 that modified caption handling when replacing images.
Why?
The conditional
isCaptionBoundlogic introduced different behavior for bound vs unbound captions, breaking the image block's existing pattern of preserving user-entered captions when replacing images.How?
Removed the conditional logic that treated bound and unbound captions differently. The image block now consistently omits empty media library captions to preserve existing user-entered captions, regardless of binding state.
Before (introduced in #73552):
After (restored original behavior):
Testing Instructions
Testing Instructions for Keyboard
Same as above using keyboard navigation to select and replace the image.
Screenshots or screencast
N/A - behavior restoration, no UI changes
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.