Fix CI static analysis on Windows#73911
Conversation
|
Deleting the |
|
Confirmed this solves the issue on a Windows machine, marking the PR as ready. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in ee33198. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20131655863
|
|
Thanks @aduth and @t-hamano and apologies , I can't believe I didn't see that 🤦 I tried shipping this ASAP to get trunk back ready (especially since, as far as I know, most active contributors don't have a Windows environment to test); this gets the job done, but if you find the other approach more suitable, by all means feel free to ship it. |
|
I just cherry-picked this PR to the release/22.3 branch to get it included in the next release: 986ec35 |
What?
Tries to fix the Windows CI build failure as a follow-up to #73860.
Why?
The plugin is passing an absolute Windows path to Terrazzo's outputFile function. Internally,
outputFilecalls newURL(filename, config.outDir), which fails because Windows paths are not valid URL strings.How?
Instead of converting URLs to paths, work entirely with URLs; this is cross-platform because the URL API handles path differences automatically.
Testing
Check that
npm run --workspace @wordpress/theme buildpasses locallyScreenshots