Fix query pattern selection so query variation patterns can appear #73901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
the
[Type] Bug
tellthemachines
requested review from
ajitbohra and
fabiankaegy
as code owners
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
ramonjd
approved these changes
Dec 11, 2025
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
| Before | After |
|---|---|
 |
 |
Also did a general smoke test of query blocks. LGTM
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I can confirm this fixes it. Thanks for the fast reaction! 🙇 |
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes issue described here. When a Query block variation has several patterns, the "Change design" button should appear in its toolbar. It wasn't appearing because in filtering to check that the patterns have Query as their root block, we were using the variation name instead of the actual block name.
Testing Instructions
The patterns for the Sensei block are looking a bit squished, not sure why (cc @m1r0):
But this is a block variation I vibe coded for testing purposes: