Theme: Ensure build artifacts are synced in version control#73894
Merged
Theme: Ensure build artifacts are synced in version control#73894
Conversation
aduth
added
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
This reverts commit 2109745.
Member
Author
|
The example problematic code fails as expected (see action run logs), reverted in 619e9e0: |
tyxla
reviewed
Dec 11, 2025
| "other:changelog": "node ./bin/plugin/cli.js changelog", | ||
| "other:check-licenses": "concurrently \"node ./bin/check-licenses.mjs\" \"wp-scripts check-licenses --dev\"", | ||
| "preother:check-local-changes": "npm run docs:build", | ||
| "preother:check-local-changes": "npm run docs:build && npm run --workspace @wordpress/theme build", |
Member
There was a problem hiding this comment.
Will this be enough? Is it possible the check is green but something gets merged in the meantime that results in this broken in trunk again?
Member
Author
There was a problem hiding this comment.
I can't imagine a scenario where that would happen. The build artifacts are deterministic based on the source tokens, so the result from the build script should always be what we want to exist in trunk. Same as how we think about the npm run docs:build and npm install commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the existing "Check local changes" continuous integration step to validate correctness of the
@wordpress/themepackage built artifacts.Why?
Prior to these changes, there were no assurances that the files generated from the package build were accurate. Since the artifacts are tracked in version control, the changes here provide assurances that they are in sync with the source files.
Testing Instructions
Validate that the temporary test commit in this branch produces an expected build failure, and that the build failure goes away after the temporary change is reverted.