-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Style Book: Fix ESLint warnings #73882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: +9 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fef8f60. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20102658444
|
ramonjd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spotting, thanks @Mamaduka
Works in my testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thank you, Ramon! And I'm not hunting (👻 ) your code 😄 |
Mamaduka A.K.A "The Cleaner" 😆 |
What?
PR fixes ESLint warnings for
scrollToSectionside-effect and simplifies its conditions.Warnings
Testing Instructions
Testing Instructions for Keyboard
Same.