-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Font Library: Allow access for hybrid themes #73876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 6e196e4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20098313607
|
|
Not sure about replacing |
That's right. What if we change the conditional statement to this: if ( ! wp_is_block_theme() && ! wp_theme_has_theme_json() ) {
return;
}I also noticed that the global styles doesnn't work for themes that don't have a theme.json. I think this is because the initial data is only inserted if the theme has a theme.json. |
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I also noticed that the global styles doesn't work for themes that don't have a theme.json. I think this is because the initial data is only inserted if the theme has a theme.json.
I have submitted a core ticket regarding this concern: https://core.trac.wordpress.org/ticket/64402
This PR allows access to the font library for classic themes with theme.json files (sometimes called hybrid themes).
Testing instructions
I've tested on Astra which fits this description but I'd love some testing on this because I don't have much experience with such themes.