Size Change: +19 B (0%)

Total Size: 2.58 MB

_{compressed-size-action}

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @slrslr.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: slrslr.

Co-authored-by: tyxla <[email protected]>
Co-authored-by: jsnajdr <[email protected]>
Co-authored-by: mcsf <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: provenself <[email protected]>
Co-authored-by: annezazu <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Flaky tests detected in 59b46d5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20096388081
📝 Reported issues:

• [Flaky Test] should open and edit templates correctly when active_templates experiment is disabled #73743 in /test/e2e/specs/site-editor/template-id-format.spec.js
• [Flaky Test] should open and edit templates correctly when active_templates experiment is enabled #73752 in /test/e2e/specs/site-editor/template-id-format.spec.js

Thanks for the quick review, Jarda 🙌

This is so minor but why do we have a "Please," here rather than just "Please" :D

This is so minor but why do we have a "Please," here rather than just "Please" :D

If I were you, I wouldn't assume non-native English speakers are familiar with the intricacies of the language 😅

I've always known "Please, " and "Please " are both valid, but never really knew the difference. In my native tongue (Bulgarian) the comma is actually recommended there, which is what likely tilted the scale 😉

A quick research says that adding a comma adds emphasis on the "please", which I agree we don't really want here. I appreciate your nudge; it's always good to learn something new.

Will follow-up shortly to remove the extra comma. Thanks @annezazu!

Follow-up to remove the comma here: #73907

N.B.: What follows is a language detour just for the fun of it.

This is so minor but why do we have a "Please," here rather than just "Please" :D

If I were you, I wouldn't assume non-native English speakers are familiar with the intricacies of the language 😅

I've always known "Please, " and "Please " are both valid, but never really knew the difference. In my native tongue (Bulgarian) the comma is actually recommended there, which is what likely tilted the scale 😉

A quick research says that adding a comma adds emphasis on the "please", which I agree we don't really want here. I appreciate your nudge; it's always good to learn something new.

Will follow-up shortly to remove the extra comma. Thanks @annezazu!

I can add that, in all the Romance languages I know, similar recommendations exist. Not in German for this particular situation, but overall it also uses the comma more. My inferrence over the years has been that contemporary English puts a lot of weight on commas. Often, as far as I know, it's not that their presence is wrong (they provide a synctatic, semantic or rhythmic function), but they are perceived to either emphasise too much or to break the flow of the sentence too much. Whereas in Romance languages — and I don't know about Bulgarian — I like to say about commas that you don't pronounce them, but you acknolwedge them. 😄