Block API: Fallback to all attributes when checking for unmodified block #73867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Block API
Mamaduka
commented
Dec 10, 2025
Comment on lines
+52
to
+55
| return ( | ||
| Object.keys( block.attributes[ key ]?.bindings ?? {} ) | ||
| .length > 0 | ||
| ); |
Member
Author
There was a problem hiding this comment.
I skipped on this idea originally, but it became an obvious choice when working on this fix. Otherwise, the fallback doesn't work.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9.x Editor Tasks
|
Size Change: +21 B (0%) Total Size: 2.57 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Dec 10, 2025
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for the testing instructions, I could reproduce the issue in trunk by removing the content role from the content attribute in the paragraph block, and this PR fixes it up nicely 👍
Left a drive-by comment but it's not in any way significant so feel free to ignore.
LGTM!
|
Flaky tests detected in 7067c14. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20087284123
|
Mamaduka
added
the
Backport to WP Minor Release
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9.x Editor Tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #73851
This is a follow-up to #70764 and #70897.
PR adds fallback logic to
isUnmodifiedBlockhelper to maintainn original behavior for blocks that haven't yet started using attribute roles.Why?
Attribute roles are relatively new, and not all blocks have adopted them. The editor should maintain the previous behavior for them - check for any attribute modification as a fallback.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screencast