Skip to content

Classic Block: Restore HTML editing option #73865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mamaduka merged 1 commit into from
Dec 10, 2025
Merged

Classic Block: Restore HTML editing option #73865

Mamaduka merged 1 commit into from
Dec 10, 2025

Conversation

@Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Dec 10, 2025

What?

Closes #73792.
Re-opens #10837.

PR restores HTML editing functionality for the Classic block, based on the feedback from #73792.

Let's try to solve the original problem using autop and Classic: #10837 (comment).

Testing Instructions

  1. Open a post.
  2. Insert the Classic block with some content.
  3. Confirm you can edit its content as HTML for the block options dropdown.

Testing Instructions for Keyboard

Same.

@Mamaduka Mamaduka self-assigned this Dec 10, 2025
@Mamaduka Mamaduka added the [Type] Regression Related to a regression in the latest release label Dec 10, 2025
@Mamaduka Mamaduka requested a review from ajitbohra as a code owner December 10, 2025 03:45
@Mamaduka Mamaduka added [Block] Classic Affects the Classic Editor Block Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release labels Dec 10, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @GovardhaneNitin, @jfacemyer, @DavidBorrink.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: GovardhaneNitin, jfacemyer, DavidBorrink.

Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: ellatrix <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka changed the title Classic Block: Resotre HTML editing option Classic Block: Restore HTML editing option Dec 10, 2025
t-hamano
t-hamano approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I never imagined anyone would use HTML editing in the Classic block 😅 This approach seems fine for now.

@Mamaduka
Copy link
Member Author

Mamaduka commented Dec 10, 2025

Everyone is using WP in different ways, there's no need to break their environments if we can avoid it :)

@Mamaduka Mamaduka merged commit e56afde into trunk Dec 10, 2025
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9.x Editor Tasks Dec 10, 2025
@Mamaduka Mamaduka deleted the restore/classic-html-editing branch December 10, 2025 06:51
@github-actions github-actions bot added this to the Gutenberg 22.3 milestone Dec 10, 2025
@DavidBorrink
Copy link

DavidBorrink commented Dec 10, 2025

Hey, thank you all. We look forward to the rollout, er "rollback" when that gets released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@Mamaduka Mamaduka

Labels

Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release [Block] Classic Affects the Classic Editor Block [Type] Regression Related to a regression in the latest release

Projects

WordPress 6.9.x Editor Tasks
Status: ✅ Done

Milestone

Gutenberg 22.3

Development

Successfully merging this pull request may close these issues.

6.9 removed the "edit in HTML" feature in the Classic block, would like it restored

4 participants

@Mamaduka @DavidBorrink @t-hamano