-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Try removing top and left grid drag handles in stable (auto) mode #73864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Just tried this and pushed the result so folks can test! Having the drag handles feels less frustrating; on the other hand the results of dragging can be unexpected, as blocks grow down almost invisibly (because new rows have no intrinsic height) or they jump to the next row when being expanded to the left: dragging-inside-grid.mp4This may be why we considered disabling those drag handles in the first place 😅 Would love some opinions on this! |
|
Size Change: +30 B (0%) Total Size: 2.57 MB
ℹ️ View Unchanged
|
ramonjd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I think that whether we ultimately decide to keep the handles for bottom/right blocks or not, this PR improves on trunk so might be worth merging if there's no strong opposition to it 😄 |
No strong opposition to it from me! 😄 I like the idea of (at some point) bringing them back if there's a way to actually rearrange the blocks at the same time. Until that point, I agree with the premise of this change, that hiding the drag handles will help reduce confusion, so it seems the pragmatic change to me 👍 |
|
Thanks for the reviews folks! |






What?
Closes #63966
If the grid experiment is disabled, or when enabled, if the Grid block is in Auto mode, top and left drag handles for grid items shouldn't show.
The downside to this is, of course, that it now becomes impossible to resize by dragging a block in the bottom right hand corner of a grid, because it won't have any drag handles:
Blocks on the bottom and right sides will be limited in their draggability. Other blocks should still be draggable towards bottom and right:
I suppose it would be possible to add top/left drag handles only when blocks are on the bottom or right sides. I might experiment with that as I feel that not being able to drag at all is suboptimal.
Testing Instructions