Color Panel: Ensure minimum height for popover content#73835
Merged
Conversation
t-hamano
added
[Type] Bug
Contributor
Author
|
I think the current behavior is considered a regression introduced in 6.9. Let's backport this PR to 6.9.1. |
t-hamano
added
the
Backport to WP Minor Release
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9.x Editor Tasks
|
Size Change: -12 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e715d0c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20127804807
|
mirka
approved these changes
Dec 9, 2025
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
This is testing well for me, but it may be cleaner to put the min-height in the stylesheet (.block-editor-panel-color-gradient-settings__dropdown-content) rather than in a style attribute?
Contributor
Author
Nice idea! I would like to do that before merging. |
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9.x Editor Tasks
t-hamano
added a commit
that referenced
this pull request
Jan 21, 2026
* Color Panel: Ensure minimum height for popover content * Put min-height in stylesheet Co-authored-by: t-hamano <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: inc2734 <[email protected]>
t-hamano
added a commit
that referenced
this pull request
Jan 28, 2026
* Color Panel: Ensure minimum height for popover content * Put min-height in stylesheet Co-authored-by: t-hamano <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: inc2734 <[email protected]>
Contributor
Author
|
This PR has been backported to the |
t-hamano
removed
the
Backport to WP Minor Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
reisze: falsefrom the color popover and enforces a minimum height on the content, ensuring the popover renders properly in all scenarios.Why?
#73817 added the
resize: false( andflip: true) to the color popover settings to prevent content from being squashed when the popover is triggered near the bottom of the page:Adding the
reisze: falseworks well when the popover content is short, but if the content height exceeds the page height, the overflow content is inaccessible.5c64bc8c83f61868e58bb641d46fe72a.mp4
For color popovers,
resize:trueis not ideal because many palettes may be added by the consumer.How?
resize: false, add a min-height as an inline style. This will allow the popover to flip when triggered at the width of the page.flipistrueby default, so it's not needed.I can't think of any other good approach right now 🤔
Testing Instructions
Screenshots or screencast
58302dfcc9485354d3cd0a0a197cb6d4.mp4