Skip to content

Chore: Shorten timeout duration for Snackbar component #73814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mamaduka merged 5 commits into from
Dec 9, 2025
Merged

Chore: Shorten timeout duration for Snackbar component #73814

Mamaduka merged 5 commits into from
Dec 9, 2025

Conversation

@badasswp
Copy link
Contributor

@badasswp badasswp commented Dec 8, 2025

What?

Closes #73813

This PR attempts to adjust the timeout duration for the Snackbar component to 6 seconds.

Why?

Previously, I had raised a PR to introduce a duration prop to provide users with the ability to modify the timeout duration of the Snackbar component. However, after much concern from other contributors, it was suggested that it would be preferable to reduce the timeout duration than to introduce a prop so as to ensure a much more consistent UX experience for all WP users.

Based on @jasmussen feedback I have adjusted the duration down to 6s.

How?

This PR adjusts the NOTICE_TIMEOUT constant to 6000.

@badasswp badasswp requested a review from ajitbohra as a code owner December 8, 2025 10:58
@github-actions
Copy link

github-actions bot commented Dec 8, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: badasswp <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @badasswp! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@jasmussen jasmussen requested a review from a team December 8, 2025 11:01
@jasmussen
Copy link
Contributor

jasmussen commented Dec 8, 2025 •
edited
Loading

Thanks for the PR. I'm keen to see this land as an improvement, so I've added a reviewer for a broader ping, to see if we can make this happen.

@badasswp
Copy link
Contributor Author

badasswp commented Dec 8, 2025

Thanks for the PR. I'm keen to see this land as an improvement, so I'd added a reviewer for a broader ping, to see if we can make this happen.

Thank you @jasmussen Much appreciated.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Dec 8, 2025
@Mamaduka
Copy link
Member

Mamaduka commented Dec 8, 2025

The issue states: "The industry standard sort of sits around 5-6 seconds".

Can you share which Toast/Snackar libraries you have evaluated? Looking at Sonner, it has 4s as the default value - https://sonner.emilkowal.ski/toast#api-reference.

@badasswp
Copy link
Contributor Author

badasswp commented Dec 8, 2025

The issue states: "The industry standard sort of sits around 5-6 seconds".

Can you share which Toast/Snackar libraries you have evaluated? Looking at Sonner, it has 4s as the default value - https://sonner.emilkowal.ski/toast#api-reference.

@Mamaduka Please see:

Toast.js
React-Toastify

Just to be clear, I'm fine with whatever value we decide to use moving forward.

@Mamaduka Mamaduka mentioned this pull request Dec 8, 2025
Open
mirka
mirka approved these changes Dec 8, 2025
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this if Design is ok with it 👍 We can always re-adjust when needed.

@Mamaduka Mamaduka added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Dec 9, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Dec 9, 2025
@Mamaduka Mamaduka merged commit b8e28cb into WordPress:trunk Dec 9, 2025
42 of 43 checks passed
@github-actions github-actions bot added this to the Gutenberg 22.3 milestone Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mirka mirka mirka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 22.3

Development

Successfully merging this pull request may close these issues.

Shorten timeout duration for Snackbar component

4 participants

@badasswp @jasmussen @Mamaduka @mirka