Block Editor: remove usage of Emotion #73799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
Size Change: -10.1 kB (-0.39%) Total Size: 2.57 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 59bc5be. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19973281267
|
aduth
reviewed
Dec 5, 2025
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I'm seeing this stacked vertically, maybe a CSS order conflict?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @CreativeDive. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Dec 5, 2025
| @@ -0,0 +1,3 @@ | |||
| .single-column { | |||
Contributor
There was a problem hiding this comment.
This would also be the first usage of CSS modules in block-editor. I wonder if we should refrain at the moment and stay with regular SCSS in this package (it's ok for components and ui)
Member
There was a problem hiding this comment.
+1. We could use @t-hamano's suggested solution with inline style - #72558 (comment).
Contributor
There was a problem hiding this comment.
+1 for inline styles for now; There are a lot of ToolsPanelItems placed in a single column by using the single-column classname. Maybe a prop like isSingleColumn might be needed in the future.
Member
Author
Yes, this is a bad style order. The I initially didn't notice this because I looked at the dev version of Storybook ( The production version of Storybook doesn't have this problem. After running
I moved the style to a
I was going to write exactly the same thing 🙂 The This PR is now ready for another look. |
Mamaduka
approved these changes
Dec 8, 2025
t-hamano
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a single usage of Emotion in the Block Editor package, which caused the
block-editorscript to bundle the library independently fromcomponents. That led to two instances being active in the WordPress block editor environment.All we did use Emotion for was a single
grid-columnstyle that ensures that the two inputs inWidthHeightControlare displayed side-by-side, in two columns:This fixes #72558 as there will be only one Emotion instance remaining, in
components.