Fix package side effects for esbuild #73795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
requested review from
ajitbohra,
ellatrix,
fabiankaegy,
nerrad and
peterwilsoncc
as code owners
jsnajdr
added
[Type] Build Tooling
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
|
Flaky tests detected in f13b290. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19967391327
|
Mamaduka
approved these changes
Dec 5, 2025
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff from #73516 that fixes package side-effects for esbuild.
First, if esbuild sees an external import like
import { foo } from 'foo', sometimes the surrounding code that uses thefooimport is tree-shaked and eliminated. But can esbuild eliminate theimportstatement itself? Only if it knows for sure that the import has no side effects. If anonResolvehook handles an import as external, esbuild is not going to look up itspackage.jsonand we need to specifysideEffectsin theonResolvereturn value.Second, esbuild can't interpret bracket expansion (
{build,build-module}/{index.js,store/index.js}) in thesideEffectsvalues. Webpack can, but esbuild can't. It will interpret such a value asfalse, which is wrong. This PR expands thesideEffectsvalues into explicit lists. Esbuild understands the*and**wildcards, but nothing else.