Block Supports: Extract reusable preset input control from spacing sizes and border radius controls #73787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
8 tasks
aaronrobertshaw
changed the title
|
Size Change: -187 B (-0.01%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
ramonjd
reviewed
Dec 9, 2025
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Great work getting this up so quickly.
Looking good so far.
Kapture.2025-12-09.at.15.41.02.mp4
I think the dropdown (with lots of border radius presets) positions itself outside the window border, but it also does on trunk.
packages/block-editor/src/components/preset-input-control/index.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/preset-input-control/index.js
Outdated
Show resolved
Hide resolved
4 tasks
aaronrobertshaw
force-pushed
the
add/preset-input-control
branch
from
06744b2 to
f4e0acf
Compare
Contributor
Author
|
I have:
I think this should be addressed via a separate follow-up. Assuming that follow-up, I think this PR is ready for additional testing and review. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
requested review from
andrewserong,
talldan and
tellthemachines
ramonjd
approved these changes
Dec 11, 2025
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Nice work.
✅ Presets can be selected
✅ Custom values can be applied via toggle
✅ When excessive presets are in theme.json the control displays custom select control
✅ Values can be applied and saved correctly
✅ All global styles and block support controls still function as expected
There was a failing E2E related to the spinning button. It might be related. I kicked it off again just in case.
Otherwise, LGTM
Contributor
|
Just a quick drive-by comment: I think the e2e test will need to be updated because the string in this PR has changed from Hopefully nothing more significant than that! 🤞 (And great work on the consolidation @aaronrobertshaw!) |
Contributor
Author
|
Thanks for the reviews and testing @ramonjd and @andrewserong 🙇 I'll get this merged to unblock some of the follow-ups e.g. preset support for dimension block supports etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of:
Follow up to:
What?
Extracts a resuable control component for a
PresetInputControlthat offers a segmented slider for choosing presets, a custom value toggle, and the ability to display a CustomSelectControl instead of the custom RangeControl slider if there are too many presets.Why?
More and more block supports are going to be using presets and share a similar UI. Currently, we already have Padding, Margin, and Border Radius block supports using this type of control.
Extracting this into a new reusable component will allow us to clean up the code for the existing block support UIs (
SpacingSizesControlandBorderRadiusControl), and then leverage it across a range of new and existing block supports that need preset functionality. These include:How?
PresetInputControlPresetInputControlaims to satisfy the slightly differing needs of the existing spacing and border radius controlsSpacingSizesControlto use new preset input controlBorderRadiusControlto use new preset input controlTesting Instructions
Test the existing controls for padding, margin, and border radius. Make sure that: