Storybook: skip transpilation of build-modules files #73780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 128f703. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19960035179
|
mirka
approved these changes
Dec 5, 2025
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Works for me, but I guess this is only until we move away from Webpack?
Member
Author
The same issues are going to be there with Vite or any other bundler:
This particular patch will not fully disappear, it will be migrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff from #73516 that updates the Storybook build config so that it doesn't transpile files in
build-modulefolders. These are already transpiled bywp-build.The method is somewhat complicated: find the
babel-loaderrule added by@storybook/addon-webpack5-compiler-babeland modify itsexcludefield.I hoped to see a performance improvement, but there isn't any 🙁 My tests show that
npm run storybook:buildtimings are exactly the same before and after this PR. But I still believe it's worth doing.There's one thing that could optimize the Storybook build a lot, but I don't know how to do it. When importing stuff from a package like
@wordpress/components, it can be imported from two different places:*.story.tsxfile imports a component, it imports it from the source. For example, thebutton/stories/index.story.tsxfile has animport Button from '..'statement. That imports thesrc/button/index.tsxfile directly.@wordpress/block-editorwhich in turn importsButtonfrom@wordpress/components, then the@wordpress/componentsfiles are resolved from the transpiledbuild-modulefolder.In the end, the bundle ends up shipping two copies of the
Button.If the
import Button from '..'statement could be somehow resolved to the transpiledbuild-modulefolder, that would save a lot of duplication and double transpilation. But I don't know how to do it.If we figured it out, it would be an optimization valuable even after migrating Storybook build from webpack5 to Vite.