-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Docs: Add "Migrating Blocks for iframe Editor Compatibility" page #73778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f18457e to
b7901dc
Compare
b7901dc to
e87a2cd
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great guide.
...rence-guides/block-api/block-api-versions/block-migration-for-iframe-editor-compatibility.md
Outdated
Show resolved
Hide resolved
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @t-hamano!
We can expand migration examples as needed and cover more common cases.
P.S. To support this effort and improve documentation, I wonder if a call for testing would be helpful? Maybe folks can share their blocks that fail with iframe, and we can provide public examples for migration. Later included in docs.
cc @annezazu
Co-authored-by: George Mamadashvili <[email protected]>
|
Thanks for your reviews, everyone! Let's continually improve the documentation based on consumers' feedback. |
|
Flaky tests detected in e8bb825. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20023948265
|
The first iteration of #73138
What? Why?
While this is not yet certain, in WordPress 7.0, the post editor will always run as an iframe.
This PR adds clear documentation to help block developers test their blocks in the iframe editor beforehand and resolve any technical concerns.
I hope to use this documentation as a starting point and consider updating it as needed based on developer feedback.
cc @annezazu
Note: I plan to update the link that the browser console warning points to with this new documentation link and ship it with 6.9.1.
How?
I have created a subpage of the "API Versions" page, consolidating the following three resources onto one page:
Testing Instructions
Please check the following two pages. If any sections are inappropriate or incorrect, please feel free to push changes.