Fix: Default color variations not showing in global styles #73742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Dec 4, 2025
|
|
||
| const context = useMemo( () => { | ||
| let merged = { ...base, ...variation }; | ||
| let merged = mergeGlobalStyles( base, variation ); |
Member
There was a problem hiding this comment.
Makes sense. The code was previously using mergeBaseAndUserConfigs private util, which was doing the same thing as mergeGlobalStyles.
Contributor
Author
|
@Mamaduka Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #72599
What?
This PR will correctly display the default variation color in the Color Variations section of the global styles.
Why?
I think we should perform a deep merge, not a shallow merge here.
Testing Instructions
Access Editor > Global Styles > Browse Styles > Color Variations
Screenshots or screencast