Global Styles: Fix 'useSelect' warning#73728
Conversation
Mamaduka
added
[Type] Code Quality
| }; | ||
| const DEFAULT_QUERY = { per_page: 100, page: 1 }; | ||
| const EMPTY_ARRAY: RawRevision[] = []; | ||
| const EMPTY_ARRAY: [] = []; |
There was a problem hiding this comment.
Probably not the best type, but it works and compiles :)
There was a problem hiding this comment.
That's OK, unless we want to have multiple EMPTY_ARRAYs 😉
There was a problem hiding this comment.
Right, we only want a single stable fallback.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| }; | ||
| const DEFAULT_QUERY = { per_page: 100, page: 1 }; | ||
| const EMPTY_ARRAY: RawRevision[] = []; | ||
| const EMPTY_ARRAY: [] = []; |
There was a problem hiding this comment.
That's OK, unless we want to have multiple EMPTY_ARRAYs 😉
|
Thanks for the review, @tyxla! |
2 participants
What?
This is a follow-up to #72599.
PR fixes the
useSelectwarning inuseGlobalStylesRevisionshook.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast