Skip to content

Notes: Avoid incrementing comment_count when notes are resolved or reopened #73689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-hamano merged 1 commit into from
Dec 3, 2025
Merged

Notes: Avoid incrementing comment_count when notes are resolved or reopened #73689

t-hamano merged 1 commit into from
Dec 3, 2025

Conversation

@t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Dec 2, 2025 •
edited
Loading

What?

This PR fixes incrementing comment_count when notes are resolved or reopened, which has been fixed in core.

Why?

Backward compatibility.

Testing Instructions

Note: This problem has already been fixed in the latest WordPress core, so don't forget to downgrade the WordPress version to 6.8 and test it.

@t-hamano t-hamano self-assigned this Dec 2, 2025
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting labels Dec 2, 2025
@t-hamano t-hamano force-pushed the exclude-notes-from-comment-count branch from c39187e to be22e04 Compare December 2, 2025 09:30
@t-hamano t-hamano marked this pull request as ready for review December 2, 2025 09:31
@github-actions
Copy link

github-actions bot commented Dec 2, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano mentioned this pull request Dec 2, 2025
Closed
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Flaky tests detected in be22e04.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19853748785
📝 Reported issues:

Mamaduka
Mamaduka approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @t-hamano!

@t-hamano t-hamano merged commit 9d90215 into trunk Dec 3, 2025
40 checks passed
@t-hamano t-hamano deleted the exclude-notes-from-comment-count branch December 3, 2025 09:24
@github-actions github-actions bot added this to the Gutenberg 22.3 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@t-hamano t-hamano

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 22.3

Development

Successfully merging this pull request may close these issues.

3 participants

@t-hamano @Mamaduka