Pattern insertion: drag chip when multiple blocks of the same type in a pattern are dragged #73681
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoids NotSupportedError when patterns contain multiple blocks of the same type.
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +16 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Dec 2, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
This is testing well for me, and the solution makes sense ✅
Member
Author
|
Thanks for the quick review @Mamaduka |
Contributor
|
Nice one, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73338
Description
Fixes a bug where dragging patterns with multiple blocks of the same type throws a
NotSupportedErrorand leaves the drag chip visible after drop.Root cause: The code added duplicate block types to
dataTransfer.items, which the browser disallows. This error prevented the drag from completing, sostopDragging()wasn't called.Solution: Track unique block types with a
Setand add each type only once.Fixes #73338
Testing Instructions
NotSupportedError: Failed to execute 'add' on 'DataTransferItemList'Additional test cases:
Screenshots or screencast
Kapture.2025-12-02.at.13.47.56.mp4