Fix block toolbar icon CSS when using show icon label preference #73674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS for the block toolbar icon was refactored to remove it from the block switcher. This refactor caused a minor regression in the styles for the show icon label preference. The CSS should have been scoped to the block toolbar, but was instead scoped to any instance of the block icon. This fix applies the correct scope.
jeryj
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Dec 1, 2025
Comment on lines
+198
to
+200
| width: 0 !important; | ||
| height: 0 !important; | ||
| min-width: 0 !important; |
Member
There was a problem hiding this comment.
I know this is prior art, so it's not a blocker, but: any alternatives to using !important here?
Contributor
Author
There was a problem hiding this comment.
The specificity is high enough without the ! important that these styles apply, but this is the rare occasion where I'd argue for !important. These rules are what is enforcing the Show block labels option. We'd be more likely to have a regression by removing the !important rules. Regressions to this are common, as it's not a feature many devs use. So, in general, I love to remove !important rules, but I think we should leave these.
Contributor
|
Thanks for fixing this Jerry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes issue reported in comment by @tellthemachines
The block switcher was refactored to not handle the default block icon of the toolbar in #72935. This refactor caused a minor regression in the styles for the show icon label preference. The CSS should have been scoped to the block toolbar, but was instead scoped to any instance of the block icon. This fix applies the correct scope.
Why?
Fix the layout of the slash inserter and global styles blocks when using the show icon labels preference
How?
Scope the CSS to the block toolbar instead of all block icons (as it was before).
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Style Block Panel
Slash Inserter