Fix Page List block button HTML rendering to escape at output #73641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a follow-up to #73614. Fixes inconsistency in the Page List block frontend rendering where buttons were escaping HTML (showing raw markup) while links rendered HTML correctly. Both buttons and links now render HTML formatting consistently.
Why
After #73614 fixed the editor rendering, there remained an inconsistency in the frontend PHP code:
esc_html( $title )which escaped HTML, showing raw markup$titledirectly (after early sanitization), rendering HTML correctlyAdditionally, the code was sanitizing early (using
wp_kses_post()on line 195) rather than at the point of output, which reduces resilience and clarity.How
$titlevariablewp_kses_post()at the point of output for both buttons (line 206) and links (line 209)Escaping at the point of output is preferred because:
Testing Instructions
<strong>Bold Title</strong>)openSubmenusOnClickenabled<strong>tags)