Skip to content

Notes: Ensure notes never show on the comments page #73640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-hamano merged 1 commit into from
Nov 29, 2025
Merged

Notes: Ensure notes never show on the comments page #73640

t-hamano merged 1 commit into from
Nov 29, 2025
+14 −0

Conversation

@t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Nov 28, 2025 •
edited
Loading

What?

This PR ensures notes never show on the comment list page.

Why?

See: https://core.trac.wordpress.org/ticket/64198

How?

To mimic this process in the Gutenberg plugin, we do the opposite: if comment_type is set to note, we unset the type field.

Testing Instructions

Note: This issue has been resolved in the latest WordPress core, so don't forget to downgrade the WordPress version to 6.8 and test it.

  1. Add a note.
  2. Access: http://localhost:8888/wp-admin/edit-comments.php?comment_type=note.
  3. The notes should not be visible.

@t-hamano t-hamano self-assigned this Nov 28, 2025
@t-hamano t-hamano added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Bug An existing feature does not function as intended labels Nov 28, 2025
@t-hamano t-hamano mentioned this pull request Nov 28, 2025
Closed
@t-hamano t-hamano marked this pull request as ready for review November 28, 2025 08:26
@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano merged commit fc5e862 into trunk Nov 29, 2025
54 of 55 checks passed
@t-hamano t-hamano deleted the notes-ignore-note-from-comment-list branch November 29, 2025 08:41
@github-actions github-actions bot added this to the Gutenberg 22.3 milestone Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@t-hamano t-hamano

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 22.3

Development

Successfully merging this pull request may close these issues.

3 participants

@t-hamano @Mamaduka