Template Activation: Update template ID format test #73629
Merged
+46
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Bug
ellatrix
reviewed
Nov 27, 2025
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
reviewed
Nov 27, 2025
| await expect( saveButton ).toBeDisabled( { timeout: 5000 } ); | ||
| } | ||
|
|
||
| await expect( page.locator( 'body' ) ).not.toContainText( |
Member
There was a problem hiding this comment.
I wonder if there could be another way to check if the template saved. Checking for this error seems a bit fragile, the text might change, and then this will no longer catch a regression.
Member
Author
There was a problem hiding this comment.
I tried checking for the templates API response but it kept timing out. This is what I tried:
await page.waitForResponse( ( response ) => {
return (
response.url().includes( '/wp/v2/templates' ) &&
response.status() === 200
);
} );
Member
There was a problem hiding this comment.
I think in other tests, we're just checking the front-end. Maybe we can try that?
Member
Author
There was a problem hiding this comment.
I figured out how to use saveSiteEditorEntities correctly... I don't think we need to check the front end or the error text anymore, the save utility fails correctly now 😄 Fixed in 00020e7.
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 99a9019. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19744578455
|
scruffian
approved these changes
Dec 3, 2025
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Looks good, thanks for following up!
Member
|
Hey, folks It seems this e2e test became very flaky since this PR got merged - #73752. |
Member
Author
|
Oh no, thanks @Mamaduka. Will take a look soon. |
Member
|
Thank you, @mikachan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the template ID format test to include two edits to the template, as this is what was causing the original bug.
Why? / How?
Ensure test covers regression by including two edits to the template.
Testing Instructions