Skip to content

Conversation

@oandregal
Copy link
Member

@oandregal oandregal commented Nov 27, 2025

What?

This PR improves the existing DataViews stories:

  • Remove "custom empty" story and merge into the "empty" one.
  • Add controls for:
    • boolean: customEmpty. Whether to display a custom empty component.
    • boolean: isLoading. Displays the loading state.
    • select: container height.
      • auto: no height defined for the container, so height is the content (empty or loading state)
      • 50vh: half of viewport
      • 100vh: full viewport, the empty and loading states are vertical aligned in the screen
Screen.Recording.2025-11-27.at.12.47.25.mov

Why?

To provide a better curation of what the component can do, and better demonstrate different states.

Testing Instructions

  • Visit "DataViews > Empty" story in local storybook (npm run storybook:dev).
  • Play with the controls.

@oandregal oandregal self-assigned this Nov 27, 2025
@github-actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <[email protected]>
Co-authored-by: ntsekouras <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal oandregal added [Type] Developer Documentation Documentation for developers [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 27, 2025
@github-actions
Copy link

Flaky tests detected in 4b4a267.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19735212005
📝 Reported issues:

@oandregal oandregal enabled auto-merge (squash) November 27, 2025 12:16
@oandregal oandregal merged commit 4b74246 into trunk Nov 27, 2025
41 of 43 checks passed
@oandregal oandregal deleted the update/dataviews-story-empty branch November 27, 2025 12:23
@github-actions github-actions bot added this to the Gutenberg 22.3 milestone Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants