Skip to content

Block JSON schema: add visibility key to supports definition #73612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shimotmk merged 4 commits into from
Nov 27, 2025
Merged

Block JSON schema: add visibility key to supports definition #73612

shimotmk merged 4 commits into from
Nov 27, 2025

Conversation

@shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Nov 27, 2025 •
edited
Loading

What?

Related #57373

This PR adds visibility key to supports definition in block.json schema.

Why?

How?

Testing Instructions

You should see the visibility key listed in the supports property.

visibility

@shimotmk shimotmk self-assigned this Nov 27, 2025
@shimotmk shimotmk added [Type] Developer Documentation Documentation for developers [Feature] Blocks Overall functionality of blocks labels Nov 27, 2025
@github-actions
Copy link

github-actions bot commented Nov 27, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

t-hamano
t-hamano reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Can you add the visibility section to the end of this file following the format of the other sections?

@t-hamano t-hamano added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Nov 27, 2025
@shimotmk
Copy link
Contributor Author

shimotmk commented Nov 27, 2025

@t-hamano
Thank you! I fixed it

t-hamano
t-hamano approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Flaky tests detected in d8e276f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19734122611
📝 Reported issues:

@shimotmk shimotmk merged commit 7a271df into trunk Nov 27, 2025
34 checks passed
@shimotmk shimotmk deleted the block-json-schema-visibility branch November 27, 2025 12:54
@github-actions github-actions bot added this to the Gutenberg 22.3 milestone Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano approved these changes

@getdave getdave Awaiting requested review from getdave

@ajlende ajlende Awaiting requested review from ajlende

@scruffian scruffian Awaiting requested review from scruffian

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@shimotmk shimotmk

Labels

Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release [Feature] Blocks Overall functionality of blocks [Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

Gutenberg 22.3

Development

Successfully merging this pull request may close these issues.

3 participants

@shimotmk @t-hamano