Site Editor Pages: add "notes count" field #73609
Merged
+122
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
oandregal
commented
Nov 27, 2025
Comment on lines
+39
to
+42
| notes.forEach( ( note ) => { | ||
| const postId = note.post; | ||
| counts[ postId ] = ( counts[ postId ] || 0 ) + 1; | ||
| } ); |
Member
Author
There was a problem hiding this comment.
This displays all the notes, regardless of status or whether the note is a top-level or a response. It mimics what we do in "wp-admin > Posts" where we also list all the comments (not only the top-level ones):
(the post has 3 comments, 2 of them top-level, another as a response to an existing comment)
oandregal
commented
Nov 27, 2025
| thumbnail?: string; | ||
| comments?: string; | ||
| editor?: boolean; | ||
| editor?: boolean | [ EditorSupport ]; |
Member
Author
There was a problem hiding this comment.
Support for editor.notes landed a month ago at WordPress/wordpress-develop@c62fe7e#diff-ef9c5475561d459917dac57d21e08a6dfeb36f8b1c44b978d3696aec8b97c405
oandregal
commented
Nov 27, 2025
Comment on lines
+184
to
+188
| if ( processedRecords ) { | ||
| return processedRecords.map( ( record ) => ( { | ||
| ...record, | ||
| notesCount: notesCount[ record.id ] ?? 0, | ||
| } ) ); |
Member
Author
There was a problem hiding this comment.
This works and it's fine. One thing I'd like to investigate further is: how do we automatically "register data for an entity"? This is for a separate follow-up. We already have registerEntityField, and there's established mechanisms on WordPress (post meta).
|
Size Change: +282 B (+0.01%) Total Size: 2.55 MB
ℹ️ View Unchanged
|
oandregal
changed the title
Notes field
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Would it make sense to include filter support, so the user can filter the pages with notes?
| return counts; | ||
| }, [ notes ] ); | ||
|
|
||
| return { notesCount, isResolving }; |
Member
There was a problem hiding this comment.
We are not using isResolving, should we use it somewhere? If not do we need to return it for now?
Member
|
We have some bugs we could press the notes column add a filter, filter by value but it does not work. If we don't support filters we should hide the option for now. Another issue is if we sort by notes data disappears and becomes empty. |
Member
Author
|
@jorgefilipecosta I've disabled filter and sorting at ff12fcc For these to work, we'd need to improve the Post endpoint, so we can sort by comments (notes). Curiously, this does work in wp-admin: Screen.Recording.2025-11-27.at.16.58.20.movIt's supported by the table and the query. But it's not supported at the endpoint level. We'd need to add support for notes (not comments), if we wanted sort. Same for filtering. |
jorgefilipecosta
approved these changes
Nov 27, 2025
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Tested well for me, thank you for the fixes @oandregal 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73606
What?
Adds a new note field in the Site Editor > Pages.
Why?
See #73606
How?
notesCountfields.editor.notes.Testing Instructions
Notesfield (via cog/view config, or via right-click in the column header).