-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Site Hub: Use optional chaining on currentTheme #73587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: +1 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
ntsekouras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the fix! Fortunately, this issue does not appear to occur in 6.9 RC3. |
Co-authored-by: mikachan <[email protected]> Co-authored-by: ntsekouras <[email protected]>
|
I just cherry-picked this PR to the release/22.1 branch to get it included in the next release: 91fcf6e |
|
@t-hamano We've received reports of broken sites and we'd like to offer a quicker fix for them ahead of the stable release later today. |
What?
This fixes a console error when visiting the Site Editor on a mobile viewport:
TypeError: Cannot read properties of null (reading 'theme_supports')Why?
Allows the Site Editor to load in a mobile viewport.
How?
Adds optional chaining to
currentTheme, as we usually do when usinggetCurrentTheme().Testing Instructions