Template Activation: Rename gutenberg_get_block_template #73582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Bug
mikachan
requested review from
ellatrix
and removed request for
spacedmonkey
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mikachan
added
No Core Sync Required
ellatrix
reviewed
Nov 26, 2025
Contributor
|
I'm surprised we added |
ellatrix
approved these changes
Nov 26, 2025
mikachan
changed the title
mikachan
added
Backport to Gutenberg RC
Member
Author
|
I just cherry-picked this PR to the release/22.2 branch to get it included in the next release: 5c38ef1 |
mikachan
added a commit
that referenced
this pull request
Nov 28, 2025
* Allow 2 args in gutenberg_get_block_template * Fix copy paste error * Simplify fix * Update function name Co-authored-by: mikachan <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: scruffian <[email protected]>
mikachan
added
Backport to Gutenberg Minor Release
mikachan
added a commit
that referenced
this pull request
Dec 3, 2025
* Allow 2 args in gutenberg_get_block_template * Fix copy paste error * Simplify fix * Update function name Co-authored-by: mikachan <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: scruffian <[email protected]>
Member
Author
|
I just cherry-picked this PR to the release/22.1 branch to get it included in the next release: abbe408 |
mikachan
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes the following error, which can be triggered by plugins calling the old
gutenberg_get_block_templatefunction with two arguments when the Template Activation experiment is enabled:Fatal error: Uncaught ArgumentCountError: Too few arguments to function gutenberg_get_block_template(), 2 passed in /wp-content/plugins/directorist/blocks/includes/class-block-templates-controller.php on line 93 and exactly 3 expected in /wordpress/plugins/gutenberg/22.1.2/lib/compat/wordpress-6.9/template-activate.php:591This example is from the Directorist plugin, but this would happen for any plugin using this function with two args.
Why?
Prevents fatal errors from
gutenberg_get_block_template().How?
Allows all three args to be
null, and if there are only two passed, treat them asget_block_template()would treat two args.Testing Instructions
gutenberg_get_block_templatefunction with 2 args, e.g. Directorist