Patterns: check for prevent default on event to enable media placeholder button #73564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…diting behavior - Updated logic to check if the click is outside the edited block before preventing default actions. - Ensured that default behavior (e.g., file dialogs) works when clicking inside the block. - Simplified the condition for stopping editing to enhance user experience.
ramonjd
requested review from
aaronrobertshaw,
andrewserong,
talldan and
tellthemachines
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Nov 26, 2025
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Appreciate the fix @ramonjd 🚀
This is working as advertised for me:
✅ Could replicate original issue
✅ Can successfully upload images after applying fix
Screen.Recording.2025-11-26.at.12.27.52.pm.mp4
Member
Author
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #73563
Modifies use-edit-content-only-section-exit.js to only call
preventDefault()when clicking outside the edited section. Clicks inside the section now allow default behavior, so the file dialog opens.Why?
In content-only mode, clicking the "Upload" button in the media placeholder didn't open the file dialog because
event.preventDefault()was called for all clicks, even inside the edited section.Testing Instructions
Try for other media/file blocks:
Screenshots or screencast
Kapture.2025-11-26.at.12.47.15.mp4