Preview Styles: Prevent leaked shadow due to blur #73545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
requested review from
andrewserong,
ramonjd,
t-hamano and
tellthemachines
aaronrobertshaw
added
[Type] Bug
6 tasks
|
Size Change: +41 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b12317f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19668924918
|
ramonjd
approved these changes
Nov 25, 2025
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
I need a new prescription for my glasses. You must have 20:20 vision!
I could hardly see the difference. Here I am squinting at my monitor like Mr Magoo.
It was much more obvious on my mac studio monitor.
Kapture.2025-11-26.at.10.09.26.mp4
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @poligilad-auto. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
With tired eyes I was having some trouble too. But it was one of those things that once you see it you can't unsee it. Thanks for the speedy review. |
Contributor
|
Wow, eagle eyes! Good catch 🎉 |
Contributor
Author
|
Credit for the eagle eyes goes to @poligilad-auto. Thanks for submitting the issue Poli 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #73351
Prevents a shadowy blur from leaking beyond the bounds of the Preview Styles component.
Why?
It's a subtle visual bug but these add up to detract from overall perceived quality.
How?
Set
clip-path: border-boxon the preview component's wrapper.Testing Instructions
Screenshots or screencast