Field API format: fix and use WordPress input #73538
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Bug
| format = field.format as Required< FormatDate >; | ||
| } | ||
|
|
||
| return dateI18n( format.weekStartsOn, getDate( value ) ); |
|
This is a time-sensitive issue that fixes an issue for tomorrow's release. I've asked around, but there are no reviewers available, so I'm going to go ahead and merge the fix. Happy to do any follow-ups post-merge. 🙏 |
What?
This fixes a bug in the
formatprop that rendered the date format incorrectly. Additionally, theformatis not set like it is in WordPress (via 0-6 numbers, and not via sunday-saturday strings).Before:
After:
Why?
Testing Instructions