What?

Follow up to:

• Use color panel for contentOnly pattern editing #71982

This PR fixes a bug where the Styles tab was showing in the block inspector when it shouldn't. I noticed this while testing out the HTML block while I had the contentOnly experiment running.

Why?

In #71982 the styles tab (and color controls) were enabled to be exposed in content only mode while editing content for patterns. It looks like there's an unnecessary check for the experiment in the styles tab that was forcing it to always be displayed. This isn't needed, because the check is already looking for hasStyleFills, and the controls are already adding a fill via SectionBlockColorControls which uses ColorEdit, which uses ColorInspectorControl which uses InspectorControls with the color group here.

So, we should be able to remove the experiment from the check, as the component will naturally show the color controls when needed, and this will allow us to hide the styles panel again when it shouldn't be shown (as is the case for the HTML block).

How?

DELETE the contentOnly experiment from the check in the styles tab.

Testing Instructions

• Switch on the contentOnly experiment:

• Add an HTML block.
• Give the HTML block some content, e.g.: <p>A paragraph</p> and update it
• Take a look at the right hand inspector sidebar
• On trunk, there are tabs, with an empty Styles tab, and the Edit Code button sitting too high
• With this PR applied, the Edit Code button should have enough space around it, and there shouldn't be any tabs
• To make sure this is still playing nicely with patterns, go to insert a pattern (i.e. any of the Banner patterns)
• Open up the inspector sidebar with any blocks within the pattern selected, and

Screenshots or screencast

Before

After

ContentOnly color controls should still be available