Variations global styles: replace useSetting with useStyle for fetching block variations #73533
+206
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing block variations
ramonjd
added
[Type] Bug
ramonjd
changed the title
ramonjd
commented
Nov 25, 2025
| [ name ] | ||
| ); | ||
| const [ variations ] = useSetting( 'variations', name ); | ||
| const [ variations ] = useStyle( 'variations', name ); |
Member
Author
There was a problem hiding this comment.
unit tests would have probably caught this. I'll add some
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Thanks for fixing this! The style variations are now appearing correctly, but the preview window is unstyled when selecting them. So for instance in TT5 the Heading block has an Annotation variation, which when selected should display like:
Whereas in this branch the styles aren't apparent in the preview:
Edit: the top screenshot is of WP 6.8 (before the refactor). Any changes to the variation styles should also reflect in that preview, which they aren't right now.
Member
Author
|
To confirm, this bug did not creep in to |
packages/global-styles-ui/src/variations/test/variations-panel.spec.js
Outdated
Show resolved
Hide resolved
|
Flaky tests detected in 4129351. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19658602102
|
Member
Author
Looks like that's also an existing bug. Good spotting |
Member
Author
I think this bug is separate - from what I can tell the root variation styles that are passed to I'm not sure if they ever were. I don't want to sink time into fixing it here, when we can get the variations at least working by merging this PR. |
andrewserong
approved these changes
Nov 25, 2025
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This fixes the bug of the variations not displaying. Just giving this the ✅ in case you want to get it in, so we could always look into the block preview issue separately.
Contributor
It's weird, it's like some of the block style variation styles are present (I see the button within the preview is looking okay), but not the styles at the root of the Group block. Not sure if it's to do with the |
Member
Author
yeah it's a chin scratcher. Thanks for looking more closely. git bisect led me to |
Member
Author
|
I think it's because the options are not passed to |
Member
Author
|
Fix here: #73535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The refactor in #72599 used the
useSettinghook to fetch block style variations instead ofuseStyle.This PR fixes that.
Why?
Style variations weren't being rendered to global styles panels.
Testing Instructions
Activate TT5 or some other theme with block variations.
Head to
/wp-admin/site-editor.php?p=%2Fstyles§ion=%2Fblocks%2Fcore%252Fgroup(using TT5, which has group variations)Check that you can see the variations.