UI: Add border support to Box component #73530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
[Type] Experimental
|
Size Change: +190 B (+0.01%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a0c4aed. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19831554510
|
juanfra
approved these changes
Nov 25, 2025
Member
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM ✅
box-border.mp4
aduth
force-pushed
the
add/box-border
branch
from
897a43b to
12b285b
Compare
aduth
commented
Nov 25, 2025
Comment on lines
+124
to
+123
| if ( borderColor ) { | ||
| style.borderColor = `var(--wpds-color-stroke-${ target }-${ borderColor }, var(--wpds-color-stroke-surface-${ borderColor }))`; | ||
| } |
Member
Author
There was a problem hiding this comment.
One thought I had (which we can iterate on asynchronously): Should any of these border props influence each other, or is it better for them to be independent. For example, if I do <Box borderColor="brand" />, should we default a 1px width since otherwise it doesn't really do anything? I think the upside is that it's a little more ergonomic and infers some intention, with the downside being that it may not be as predictable for certain defaulting to apply only under some circumstances.
Member
There was a problem hiding this comment.
Unless I’m misunderstanding something, my preference would be for them to be independent. I know this can be subjective. Once props start behaving in an opinionated way, things can get less predictable and potentially confusing for folks using the component.
That said, I'm not opposed to having some interplay between them if we feel it meaningfully improves things, as long as it’s clearly documented and we call out all the specific cases.
Member
Author
There was a problem hiding this comment.
Thanks for your feedback @juanfra . I'd tend to agree. It's also something we could revisit down the line as a future enhancement if it proves to be too burdensome as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses part of #72784
Updates the Box component added in #72984 to support additional border integration with design tokens.
Includes a few supporting changes to align border tokens to general structure and naming scheme.
Why?
As a foundational component, Box should be able to support the most common integrations with design tokens, including border tokens.
Testing Instructions
Verify in Storybook:
npm run storybook:devborderColor,borderRadius, andborderWidthpropsScreenshots or screencast