Real-time collaboration: Disable syncing for "synthetic" template posts #73526
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriszarate
added
[Feature] Real-time Collaboration
|
Size Change: -2 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
chriszarate
force-pushed
the
fix/disable-sync-for-templates
branch
from
2fa222f to
fd0a051
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
chriszarate
changed the title
ellatrix
approved these changes
Nov 25, 2025
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Sounds good. Checking for the numeric ID will allow user created templates to synced when the template activation feature lands, because they are real entities, while still excluding registered/static templates. This is better than checking specifically for templates. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Disable syncing for "synthetic" template posts—meaning templates that do not map directly to an entity represented in the database.
Why?
When the "created template" experiment is enabled, activated templates are synthetically represented in the store with a string identifier and a
wp_idproperty pointing to the "real" entity record.These synthetic entities do not fulfill our expectations around how entities are handled by the store. Specifically, they are not handled by the
editEntityRecordandsaveEntityRecordactions incore-data. Therefore, they cannot be synced in the same way that "real" entity records are synced.How?
Do not sync entity record with non-numeric IDs.
Testing Instructions
Testing Instructions for Keyboard
No UI changes in this PR.