Size Change: +39 B (0%)

Total Size: 2.54 MB

_{compressed-size-action}

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ellatrix <[email protected]>
Co-authored-by: mcsf <[email protected]>
Co-authored-by: joedolson <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Yes, speaking immediately on an error is going to be too verbose. In cases like this (where updates occur with a lot of frequency), I would only emit spoken notices periodically. Users need to be informed of these errors, but it is excessive if they're being informed on every keypress. There are a lot of ways to do this; setting a timer to check every few seconds, only announcing on change of focus, etc.

I'm not sure that speaking every error is the best strategy; if the error container was explicitly connected to the textarea via aria-describedby then it would be discoverable easily, and the spoken error could be fired only if there's an error present when the user is exiting the popover.

That said, this does work, and in testing I didn't find it to be a problem - the verbosity didn't get in my way. I think for the purpose of release, this passes our needs, and we can listen for user feedback and adjust if it's too verbose in real life usage.

When a user navigates out of the math block when the popover is open using arrow keys, the popover does not close. I think it would make sense for the popover to close when a user leaves the block via keyboard, same as if they change via mouse click. Currently, it only changes once the user selects a block.

Re: @mcsf's comment about moving focus immediately. I do think that when a user adds a math block, it's confusing to then have to tab to get into the editor. You expect to be able to type content immediately, as in most other blocks.

But in most blocks, you do the editing directly in the block, rather than in a popover, so the need to reverse tab to get back to the block may also be confusing. Having needed to tab in the first place may help communicate where you are in the content, for keyboard users. This could be made less of an issue with an explicit close button on the editor.

Ok let's leave the speaking as-is and see. We can debounce if necessary later.

We can focus the popover on insert, but it should be consistent between the block and format. A good example of another block that opens a popover on insert is the Page Link block, which focusses immediately, but it also works a bit differently. It's a constraint tabbing popover. The block also is removed when you press Esc or click outside it.

When a user navigates out of the math block when the popover is open using arrow keys, the popover does not close.

I'm a bit confused here. When I exit the popover by shift+tab to move focus to the block, then use arrow keys, other blocks are selected and the popover disappears? What are the steps to reproduce?

Huh. When I went to re-test, I couldn't reproduce the experience I had the first time. I'm not sure what might have been different, so I think we'll have to assume that it was an exception or an edge case, and see if it comes up again.

Ok, in that case, I'll merge :)

I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: f34ada7