-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Breadcrumbs: Improve home page and front page handling #73487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumbs: Improve home page and front page handling #73487
Conversation
|
Size Change: -2 B (0%) Total Size: 2.57 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f924572. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19574614754
|
f924572 to
c2db66a
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What?
Fixes: #73441
This PR improves home page and front page handling.
The default reading setting for
Your homepage displaysisYour latest posts. In this case WP shows a posts list andis_homeis the same withis_front_page.When users set static pages for
homepageandposts pagewe need to:homelink (front page), when we are inposts pagePage xin the case of a paged (withBreak page block) static homepage.Additionally and not related to the fix, I've renamed two block attributes. Since the block is experimental, no deprecation is needed.
Testing Instructions
posts pageoption and observe that breadcrumbs items appearPage Breakblock in thehomepageyou selected in reading settings and visit front-end. You should see the correctPage Xitem, when you click in the second page.Screenshots or screencast
Below I'm sharing some screenshots in a site that I've added x3p0-breadcrumbs plugin and the core block in the main header.
Above is x3p0-breadcrumbs and below is the core block.
Specific
posts pagesetSpecific
homepageset paged (with Page Break)