Disable TinyMCE: Polish refresh message #73485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: +12 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cb95ee6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19571972620
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mcsf
approved these changes
Nov 24, 2025
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
Pending my feedback, LGTM :)
| 'It appears you are trying to use the deprecated Classic block. You can leave this block intact, convert its content to a Custom HTML block, or remove it entirely. Alternatively, you can refresh the page to use the Classic block.' | ||
| 'It appears you are trying to use the deprecated Classic block. You can leave this block intact, convert its content to a Custom HTML block, or remove it entirely.' | ||
| ); | ||
| messageHTML += refreshMessage; |
Contributor
There was a problem hiding this comment.
This doesn't stitch together well: it's missing a space, as can be seen in the After screenshot.
My recommendation is to keep it simple, even if redundant, by modifying the two different messageHTML strings. That way, no confusion is possible for translators as to what refreshMessage is meant for, no room for translation inconsistencies is allowed, and no assumptions are made as to how sentences should be joined in all the locales.
Member
Author
There was a problem hiding this comment.
This is reasonable, thanks. Addressed in 5390fb4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As part of the Disable TinyMCE experiment, updating the message the user sees when prompted to convert a classic/freeform block.
Why?
For clarity that unsaved data needs to be saved before refreshing. See this thread for details.
How?
Just updating the message. Reusing the string to reduce translator burden - strings are long enough already.
Testing Instructions
<div class="notice">You can include <em>raw HTML</em> here.</div>.Testing Instructions for Keyboard
Same
Screenshots or screencast