Size Change: -7 B (0%)

Total Size: 2.51 MB

_{compressed-size-action}

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: talldan <[email protected]>
Co-authored-by: tellthemachines <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Before

After

Thank you for this :) such a massive win!

This PR may have allowed unintended block insertion.

For example, in the Accordion block, the children of the Accordion Item block consist only of the Accordion Heading and Accordion Panel blocks, and no other blocks can be inserted. However, applying templateLock:contentOnly allows the insertion of additional blocks.

<!-- wp:group {"templateLock":"contentOnly","layout":{"type":"constrained"}} -->
<div class="wp-block-group">
	<!-- wp:accordion -->
	<div role="group" class="wp-block-accordion">
		<!-- wp:accordion-item -->
		<div class="wp-block-accordion-item">
			<!-- wp:accordion-heading -->
			<h3 class="wp-block-accordion-heading">
				<button class="wp-block-accordion-heading__toggle"><span class="wp-block-accordion-heading__toggle-title">Accordion Title</span><span class="wp-block-accordion-heading__toggle-icon" aria-hidden="true">+</span></button>
			</h3>
			<!-- /wp:accordion-heading -->
			<!-- wp:accordion-panel  -->
				<div role="region" class="wp-block-accordion-panel">
				<!-- wp:paragraph -->
				<p>Accordion Content</p>
				<!-- /wp:paragraph -->
			</div>
			<!-- /wp:accordion-panel -->
			</div>
		<!-- /wp:accordion-item -->
	</div>
	<!-- /wp:accordion -->
</div>
<!-- /wp:group -->

Before (Expected)

After (Not expected)

@t-hamano I'll have a look at putting a fix together. From what I can tell it's not a bug caused by this PR, I think it might be existing bug that this PR has exposed.

To explain - it looks like setting contentOnly on the group is also changing the 'Accordion Item' templateLock to contentOnly even though it's been explicitly set to all. I don't think it should override a templateLock that's already been set. 🤔

It's curious, it might be a bug that's been in trunk for a while, or maybe it's how it's expected to work, but that would be surprising to me. Other templateLock options like insert don't override the existing template lock.

Actually it is in the docs for contentOnly - "Unlike the other lock types, this is not overridable by children."

I guess it's not a bug, but it means there's no way to properly lock accordion-item down if a parent sets contentOnly mode.

TBH, these blocks are very complicated for contentOnly mode. In contentOnly there should be a flatter-hierarchy that's easier to edit, so it's unexpected to have three levels. I'm not sure what the answer is though, and I can absolutely see why it was built that way. I think ideally there'd be a way to make the header and panel more built into the item (Explore a concept for composite blocks (a container block with a fixed set of inner blocks, with some UX tweaking) is related).

It looks like another related bug with the accordion block and locking:

1. Add an accordion within a group
2. Open up the lock options for the group
3. Select 'Lock all' and 'Apply to all blocks inside'

Expected: all inner blocks are locked
Actual: Users can still add inner blocks to Accordion Panel (because that block explicitly sets templateLock: false)

I think the root of the problem is the way Accordion is using templateLock isn't what it's intended for. A solution is needed for #70994.